Update Figma variables from JSON files #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceballost
reviewed
Sep 24, 2024
marcoskolodny
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Nice work! Here you have web-core backlog in case you feel like replacing us as developers from now on 😆
Co-authored-by: Marcos Kolodny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature allows the creation of figma variables by running a script in the repository.
https://www.tldraw.com/s/v2_c_snnVQbmyyGW4BzwXyXPwZ?d=v6816.-947.4025.2072.page
This script should:
paletteen each skin fileModeandBrandin a middleware fileThis middleware file is the one that will be used to link variables in all Mistica components
Each collection will appear as a selector in the UI:
Appart from the tokens defined in JSON files, we need to create figma-oriented tokens:
Test file with variables created:
https://www.figma.com/design/wlnMwpneZheC7CskSJAw4g/Middleware-POST-test-V2?node-id=0-1&node-type=canvas&t=scPU5BKt3mgO0tCf-0